microsoft / omi-script-provider

Script Provider for the OMI Project
Other
8 stars 7 forks source link

Fixed a circular reference with reference_counted_ptr that was causing a memory leak. #71

Closed EMumau closed 7 years ago

EMumau commented 7 years ago

Fixed a circular reference with reference_counted_ptr that was causing a memory leak.

Changed the library dependency order for the test project to fix progressive builds.

JumpingYang001 commented 7 years ago

you can sync your branch before you doing a new fix commit next time, so it will not show old commit in you PR, thanks.

git checkout master
git fetch
git pull origin master
git reset --hard HEAD
git checkout ermumau-work09 
git rebase master
git push origin ermumau-work09 -f

then do your fix and commit as usual:
vi file1
vi file2
git add .
git commit . -m 'my commit to fix issue 1'
git push origin  ermumau-work09

or

git status -s to check the modified files, select the need files to commit for example: folder1/file1 folder1/file2
git add folder1/file1 folder1/file2
git commit folder1/file1 folder1/file2 -m 'my commit to fix issue 1'
git push origin  ermumau-work09
JumpingYang001 commented 7 years ago

If you git rebase master failed in above commands, you can new a branch from master and push it to remote branch:

git checkout master
git branch -D ermumau-work09
git checkout -b ermumau-work09
git push origin ermumau-work09
if remote branch ermumau-work09 exist, you can force push your own remote branch:
git push origin ermumau-work09 -f