microsoft / omi

Open Management Infrastructure
Other
368 stars 116 forks source link

Make code compilable to new gcc compiler #573

Closed BingyuLiu closed 6 years ago

palladia commented 6 years ago

Not going to make a big deal since it's just sample code, but generally if you add an if statement, you should have an else...

BingyuLiu commented 6 years ago

@JumpingYang001

gcc -c -o /home/johnliu/dev/Build-omi/omi/Unix/output/obj/samples/Providers/Connector/Connector.o -g -O2 -fPIC -Werror -Wall -fvisibility=hidden -fno-strict-aliasing -fstack-protector-all -D_GNU_SOURCE -D_XOPEN_SOURCE=600 -DGSS_USE_IOV=1 -D_DEFAULT_SOURCE -I/home/johnliu/dev/Build-omi/omi/Unix/output/include -I../../.. -I../../../common Connector.c In file included from Connector.c:11:0: Connector.c: In function ‘Connector_AssociatorInstancesLeft’: /home/johnliu/dev/Build-omi/omi/Unix/output/include/MI.h:3350:21: error: ‘g.ft’ may be used uninitialized in this function [-Werror=maybe-uninitialized] if (self && self->ft)


In file included from Connector.c:12:0:
Connector.c: In function ‘Connector_ReferenceInstancesLeft’:
Connector.h:129:28: error: ‘c.__instance.ft’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
     return self->__instance.ft->SetElementAt(
            ~~~~~~~~~~~~~~~~^~~
cc1: all warnings being treated as errors
BingyuLiu commented 6 years ago

@palladia, these functions I modified are void. Do you want me to add this else, like this?

else { return; }