microsoft / onefuzz

A self-hosted Fuzzing-As-A-Service platform
MIT License
2.82k stars 199 forks source link

Better errors from Download: Make GetFileSasUrl nullable #3229

Closed Porges closed 1 year ago

Porges commented 1 year ago

This allows us to generate 404s when someone attempts to download from a non-existent container. At the moment we generate a 500 which isn't useful, or very good looks-wise.

codecov-commenter commented 1 year ago

Codecov Report

Merging #3229 (2285bc8) into main (44674e8) will increase coverage by 0.02%. The diff coverage is 42.42%.

@@            Coverage Diff             @@
##             main    #3229      +/-   ##
==========================================
+ Coverage   29.55%   29.57%   +0.02%     
==========================================
  Files         332      332              
  Lines       39199    39242      +43     
==========================================
+ Hits        11584    11607      +23     
- Misses      27615    27635      +20     
Impacted Files Coverage Δ
src/ApiService/ApiService/onefuzzlib/Extension.cs 0.00% <0.00%> (ø)
...ce/ApiService/onefuzzlib/NotificationOperations.cs 24.79% <0.00%> (-1.53%) :arrow_down:
...piService/ApiService/onefuzzlib/ProxyOperations.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/onefuzzlib/Events.cs 70.83% <85.00%> (+2.56%) :arrow_up:
src/ApiService/ApiService/Functions/Download.cs 100.00% <100.00%> (ø)
src/ApiService/ApiService/onefuzzlib/Containers.cs 74.14% <100.00%> (+0.35%) :arrow_up: