microsoft / onefuzz

A self-hosted Fuzzing-As-A-Service platform
MIT License
2.82k stars 199 forks source link

Fix some CI flakiness by separating more artifacts #3250

Closed Porges closed 1 year ago

Porges commented 1 year ago

Many jobs uploading output into the same artifact causes spurious failures unless the job which consumes the artifact depends upon all of the previous jobs. So, split the uploads into separate artifacts so that the CLI job (which is the main one that fails) can depend upon only a subset of the jobs.

Also add caching to the AFL/AFLPP builds.

codecov-commenter commented 1 year ago

Codecov Report

Merging #3250 (01e9958) into main (5583d0d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3250   +/-   ##
=======================================
  Coverage   31.45%   31.45%           
=======================================
  Files         307      307           
  Lines       37239    37239           
=======================================
  Hits        11712    11712           
  Misses      25527    25527           
Porges commented 1 year ago

We should also make sure this doesn't break check-pr

I've diffed the zip files but agreed

Porges commented 1 year ago

It did break check-pr 🙂 check-pr depends on the build artifact names and needs adjusting.

Porges commented 1 year ago

One stage in check-pr still needs to be updated before this can merge.