search

microsoft / onefuzz

A self-hosted Fuzzing-As-A-Service platform
MIT License
2.82k stars 199 forks source link

UPN changes/fixes #3289

Closed Porges closed 1 year ago

Porges commented 1 year ago

Starts to address #3158.

Rather than storing the UPN and then removing it later, do not store it in the first place.

I found one problem while working on this which was that UserInfo was not actually stored on Job, so address that as well. This was because properties which are not constructor parameters are not stored by the ORM, so I've also removed other examples from Task and Node and have them only on the response types.

Also started to simplify the ORM roundtripping tests; remove the custom equality comparison and instead simply compare JSON-serialized values. Rely on the FsCheck automatic generation of values where it works, rather than writing a custom Arbitrary which does the same thing.

codecov-commenter commented 1 year ago

Codecov Report

Merging #3289 (1d73ed2) into main (5583d0d) will increase coverage by 0.00%. The diff coverage is 89.28%.

@@           Coverage Diff           @@
##             main    #3289   +/-   ##
=======================================
  Coverage   31.45%   31.45%           
=======================================
  Files         307      307           
  Lines       37239    37202   -37     
=======================================
- Hits        11712    11703    -9     
+ Misses      25527    25499   -28
Impacted Files Coverage Δ
.../ApiService/ApiService/Functions/TimerRetention.cs 0.00% <ø> (ø)
...ApiService/ApiService/onefuzzlib/TaskOperations.cs 31.37% <0.00%> (-0.38%) :arrow_down:
src/ApiService/ApiService/OneFuzzTypes/Events.cs 74.05% <57.14%> (+0.30%) :arrow_up:
...rc/ApiService/ApiService/OneFuzzTypes/Responses.cs 77.66% <87.50%> (+0.34%) :arrow_up:
src/ApiService/ApiService/Functions/Jobs.cs 72.44% <100.00%> (ø)
src/ApiService/ApiService/Functions/Node.cs 35.43% <100.00%> (+1.03%) :arrow_up:
src/ApiService/ApiService/OneFuzzTypes/Model.cs 71.88% <100.00%> (-0.82%) :arrow_down:
src/ApiService/ApiService/OneFuzzTypes/Webhooks.cs 100.00% <100.00%> (ø)
...piService/ApiService/onefuzzlib/ReproOperations.cs 10.78% <100.00%> (ø)
...e/onefuzzlib/notifications/JinjaTemplateAdapter.cs 90.84% <100.00%> (+0.02%) :arrow_up:
... and 1 more