search

microsoft / onefuzz

A self-hosted Fuzzing-As-A-Service platform
MIT License
2.82k stars 199 forks source link

Revert "Update packaging of LibFuzzerDotNetLoader (#3248)" #3327

Closed Porges closed 1 year ago

Porges commented 1 year ago

This reverts commit 25f125748dc0352d66385281e7a4468621233739.

The change broke the libfuzzer dotnet template (I could have sworn I validated first with check-pr but…)

Two things didn't work:

  1. the path to the LibFuzzerDotNetLoader needed to change; I attempted to fix this in #3324
  2. minidumps weren't being captured, for an unknown reason. I haven't figured out why yet, thus I'm going to simply revert the change so we have this working for the next release.
codecov-commenter commented 1 year ago

Codecov Report

Merging #3327 (ffa71b6) into main (2d0d297) will decrease coverage by 1.40%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3327      +/-   ##
==========================================
- Coverage   31.81%   30.41%   -1.40%     
==========================================
  Files         307      133     -174     
  Lines       37327    14278   -23049     
==========================================
- Hits        11874     4343    -7531     
+ Misses      25453     9935   -15518

see 174 files with indirect coverage changes