Open Porges opened 1 year ago
Merging #3337 (973e672) into stacktrace-fixes (a9ac78e) will increase coverage by
0.10%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## stacktrace-fixes #3337 +/- ##
====================================================
+ Coverage 31.84% 31.94% +0.10%
====================================================
Files 307 307
Lines 37361 37421 +60
====================================================
+ Hits 11897 11954 +57
- Misses 25464 25467 +3
Files Changed | Coverage Δ | |
---|---|---|
src/agent/onefuzz/src/input_tester.rs | 0.00% <ø> (ø) |
|
src/agent/stacktrace-parser/src/asan.rs | 100.00% <ø> (ø) |
|
src/agent/stacktrace-parser/src/lib.rs | 90.79% <ø> (+0.48%) |
:arrow_up: |
With enough regular expressions, we can fix anything.
Finishes addressing #3335.
Instead of simply reusing the ASan Summary value as output for the
crash_site
, I suggest that we generate a new one in a very similar format. This allows us to point to the top stack frame of the minimized stack trace as the source of the problem, hopefully skipping non-user code. Thecrash_site
is directly used in the titles of bugs filed by OneFuzz.As an example, we currently generate:
After this change we would generate instead:
Open questions
crash_site
? This would potentially make the title generation more flexible but depends on how powerful Scriban is.Parsing improvements
At the same time I've made changes to improve how we parse the stack traces, based upon our existing corpus:
http://go/…
)<module>+offset
(unlikely we'll ever need this!)Two changes break supposed compatibility with ClusterFuzz:
These changes are good to bundle together because they affect the stack hash generation (see next section).
Fallout
If we change the stack minimization and title generation this will result in differences for bug deduplication (currently this is by default done with a combination of the title and minimized stack hash). So existing un-fixed bugs may get refiled by OneFuzz.