Remove unnecessary method argument

microsoft / onefuzz

A self-hosted Fuzzing-As-A-Service platform

MIT License

2.82k stars 198 forks source link

Remove unnecessary method argument #3473

Closed kananb closed 1 year ago

kananb commented 1 year ago

Summary of the Pull Request

Address the post-merge comments made on #3467 Essentially, I was passing a dictionary to a method that already had access to it from one of its member variables. This PR changes the code to just use the member variable instead.

PR Checklist

[ ] Applies to work item: #xxx
[ ] CLA signed. If not, go over here and sign the CLI.
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

codecov-commenter commented 1 year ago

Codecov Report

Merging #3473 (7bd4ec1) into main (14ab36e) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #3473   +/-   ##
=======================================
  Coverage   34.42%   34.42%           
=======================================
  Files         299      299           
  Lines       36259    36259           
=======================================
  Hits        12481    12481           
  Misses      23778    23778

Files Changed	Coverage Δ
...Service/ApiService/onefuzzlib/notifications/Ado.cs	`24.61% <0.00%> (ø)`