Improve area/iteration path validation

microsoft / onefuzz

A self-hosted Fuzzing-As-A-Service platform

MIT License

2.82k stars 198 forks source link

Summary of the Pull Request

The newly added checks each have their own error message for their violation, so, for example, users that delimit their paths with a forward slash instead of a backslash will get a message saying: "Area Path "Foo/Bar" is invalid. "Foo/Bar" contains an invalid character (\ / : ? " < > | ; # $ { } , + = [ ])." "Make sure that the path is separated by backslashes (\) and not forward slashes (/)."

PR Checklist

[ ] Applies to work item: #xxx

[ ] CLA signed. If not, go over here and sign the CLI.

[ ] Tests added/passed

[ ] Requires documentation to be updated

[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Codecov Report

Merging #3489 (4a67abf) into main (896329d) will decrease coverage by 8.38%. The diff coverage is 85.24%.

@@            Coverage Diff             @@
##             main    #3489      +/-   ##
==========================================
- Coverage   39.32%   30.95%   -8.38%     
==========================================
  Files         299      135     -164     
  Lines       36270    14606   -21664     
==========================================
- Hits        14264     4521    -9743     
+ Misses      22006    10085   -11921

Files Changed	Coverage Δ
src/ApiService/ApiService/OneFuzzTypes/Enums.cs	`32.39% <ø> (ø)`
...Service/ApiService/onefuzzlib/notifications/Ado.cs	`34.87% <85.24%> (+10.26%)`	:arrow_up:

... and 165 files with indirect coverage changes

microsoft / onefuzz