Scoped notification pause

microsoft / onefuzz

A self-hosted Fuzzing-As-A-Service platform

MIT License

2.82k stars 199 forks source link

Info on Pull Request

What does this include?

New containers endpoint for modifying container metadata

New CLI command for modifying container metadata (onefuzz containers update {container name} {metadata key}={metadata value})

Fixes a bug where messages requeued due to ADO_WORKITEM_PROCESSING_DISABLED have their retry count incremented. We should only increment the retry count when we actually try to process the notification

Do not attempt to process notifications for containers that are tagged with pauseNotifications=true. If that's the case, requeue the message with a 1 day timeout

Validation Steps Performed

How does someone test & validate?

Tested in dev deployment:

Create a file in a container

Check that a message was added in file-changes queue

Using the cli, set pauseNotifications=true metadata tag on the container

Create another file in the container

Check that a message was added in file-changes queue

Check that file-changes queue shows "0 of 1 messages" meaning that the message was requeued with a visibility timeout

Codecov Report

Merging #3579 (359fadb) into main (72d775f) will decrease coverage by 0.05%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3579      +/-   ##
==========================================
- Coverage   39.99%   39.94%   -0.05%     
==========================================
  Files         303      303              
  Lines       37683    37724      +41     
  Branches     1728     1738      +10     
==========================================
- Hits        15072    15070       -2     
- Misses      22289    22332      +43     
  Partials      322      322

Files	Coverage Δ
src/ApiService/ApiService/OneFuzzTypes/Enums.cs	`32.39% <ø> (ø)`
src/ApiService/ApiService/onefuzzlib/Reports.cs	`39.68% <ø> (ø)`
...ce/ApiService/onefuzzlib/NotificationOperations.cs	`18.60% <0.00%> (-0.15%)`	:arrow_down:
src/ApiService/ApiService/OneFuzzTypes/Requests.cs	`58.73% <0.00%> (-0.89%)`	:arrow_down:
src/ApiService/ApiService/Functions/Containers.cs	`70.58% <0.00%> (-11.61%)`	:arrow_down:
src/ApiService/ApiService/onefuzzlib/Containers.cs	`59.37% <0.00%> (-3.50%)`	:arrow_down:
...piService/ApiService/Functions/QueueFileChanges.cs	`8.49% <0.00%> (-0.70%)`	:arrow_down:

... and 1 file with indirect coverage changes

microsoft / onefuzz