Increasing Azure App Function Timeout to 12 Hours

microsoft / onefuzz

A self-hosted Fuzzing-As-A-Service platform

MIT License

2.82k stars 199 forks source link

Increasing Azure App Function Timeout to 12 Hours #3599

Closed nharper285 closed 9 months ago

nharper285 commented 9 months ago

Summary of the Pull Request

What is this about? While we work on a potential redesign of the azure app functions TimerWorkers and TimerTasks we are increasing the function timeout.

PR Checklist

[ ] Applies to work item: #xxx
[ ] CLA signed. If not, go over here and sign the CLI.
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

codecov-commenter commented 9 months ago

Codecov Report

Merging #3599 (4731241) into main (957f1fb) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3599   +/-   ##
=======================================
  Coverage   39.97%   39.98%           
=======================================
  Files         303      303           
  Lines       37698    37698           
  Branches     1725     1725           
=======================================
+ Hits        15071    15072    +1     
  Misses      22305    22305           
+ Partials      322      321    -1

see 1 file with indirect coverage changes

Porges commented 9 months ago

Is there a way to restrict this to certain functions? We have some that should finish in seconds, so ideally we don't want their maximum runtime to be 12 hrs.

nharper285 commented 9 months ago

Is there a way to restrict this to certain functions? We have some that should finish in seconds, so ideally we don't want their maximum runtime to be 12 hrs.

Not that I'm aware of. I don't think it's necessary, though, as we will only have this a short time and have a good way of keeping an eye on timer run length via data dashboards.