search

microsoft / onnxconverter-common

Common utilities for ONNX converters
MIT License
251 stars 66 forks source link

relax protobuf restriction #269

Closed matty-rose closed 7 months ago

matty-rose commented 11 months ago

fixes https://github.com/microsoft/onnxconverter-common/issues/265

onnx itself specifics >=3.20.2 - https://github.com/onnx/onnx/blob/main/requirements.txt#L2C17-L2C17 onnxruntime has no restriction - https://github.com/microsoft/onnxruntime/blob/main/requirements.txt.in#L5

matty-rose commented 10 months ago

@microsoft-github-policy-service agree company="Canva"

matty-rose commented 10 months ago

hi @xiaowuhu would you be able to review this PR/trigger CI checks please :)

matty-rose commented 10 months ago

or maybe @fatcat-z?

xiaowuhu commented 10 months ago

@matty-rose The 3.20.2 version is specified by Microsoft internal security checking and recommended. I just approved it to see if it can pass the CI pipeline, then waiting for some days to see if there has some security issue filed.

tianleiwu commented 9 months ago

/azp run common-linux-conda-CI, common-win32-conda-CI

azure-pipelines[bot] commented 9 months ago
Commenter does not have sufficient privileges for PR 269 in repo microsoft/onnxconverter-common
matty-rose commented 9 months ago

hey @xiaowhu @tianleiwu any update on the CI/security checking?

matty-rose commented 8 months ago

hi @xiaowhu @tianleiwu quick ping on this, any updates/anything I can do to help move this forward?

tianleiwu commented 8 months ago

@wenbingl, @snnn please help trigger CI.

snnn commented 8 months ago

/azp run common-linux-conda-CI, common-win32-conda-CI

snnn commented 8 months ago

/azp run common-linux-conda-CI, common-win32-conda-CI

xiaowuhu commented 7 months ago

@matty-rose relax it in several PRs with some other maintain work.