search

microsoft / onnxjs

ONNX.js: run ONNX models using JavaScript
Other
1.76k stars 129 forks source link

Scatter ops for webworker #220

Open Manojbhat09 opened 4 years ago

Manojbhat09 commented 4 years ago

Had to implement the pytorch scatter (torch.scatter) for an application. This is valid with onnx scatter too. And works

ghost commented 4 years ago

CLA assistant check
All CLA requirements met.

Manojbhat09 commented 4 years ago

When I do npm run pre-commit it gives this error:

Error: Cannot find module 'C:\Users\manojpc\Documents\Deepen\actual\push\onnxjs\tools\pre-commit'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}
fs-eire commented 4 years ago

When I do npm run pre-commit it gives this error:

Error: Cannot find module 'C:\Users\manojpc\Documents\Deepen\actual\push\onnxjs\tools\pre-commit'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

the pre-commit hook failed to launch. did you run npm ci and tsc correctly?

Manojbhat09 commented 3 years ago

Hi @fs-eire I actually created a test for this and it works. Do I create a new pull request now?