Add LogSoftmax for CPU - Githubissues

microsoft / onnxjs

ONNX.js: run ONNX models using JavaScript

Other

1.75k stars 130 forks source link

Open hayashikun opened 3 years ago

hayashikun commented 3 years ago

I need LogSoftmax, and I added LogSoftmax for the CPU backend. (related to #177)

This is the first time for me, so please let me confirm some points.

Regarding the test-suite-whitelist.jsonc,

I added some tests written in onnx/onnx. Is it enough?
I added a commnet line in ops because there is not log-softmax.jsonc in onnxjs-demo. Should I prepare test cases and send PR to onnxjs-demo?

Best Regards,

ghost commented 3 years ago

All CLA requirements met.

fs-eire commented 3 years ago

it looks like the build failed on pre-commit check. could you please run npm run format and check it again?

hayashikun commented 3 years ago

Thank you for your advice! CI looks to work well except BrowserStack, which has failed in other PRs.

iiSeymour commented 3 years ago

Would be godd to see this make a release (#267).

iiSeymour commented 3 years ago

I have a wasm and webgl implementation I can add also.