search

microsoft / onnxruntime-extensions

onnxruntime-extensions: A specialized pre- and post- processing library for ONNX Runtime
MIT License
295 stars 80 forks source link

[java] Setting Java module name to com.microsoft.onnxruntime.extensions #730

Closed Craigacp closed 1 month ago

Craigacp commented 1 month ago

The Java module system (introduced in Java 9) requires that all modules on the module path have unique names, and the current name for ORT-extensions collides with ORT as both use com.microsoft.onnxruntime. This PR changes the ORT-extensions module name to com.microsoft.onnxruntime.extensions to remove the collision.

If they are colliding then work needs to be done in the user's build system to pull ORT-extensions off from the module path and put it on the classpath which can be irritating to do particularly if it's consumed by a third party dependency which might not be doing a module aware build.

skottmckay commented 1 month ago

Something is up with the connection to the CI. I manually ran onnxruntime-extensions.CI here and that passed.

Once it passed, the button to check in the PR became enabled, although it still claims to be waiting on the status for the CI.

Craigacp commented 1 month ago

Is it possible to get this in to the 0.11.0 release or has that already happened?

wenbingl commented 1 month ago

Is it possible to get this in to the 0.11.0 release or has that already happened?

sorry, the release team are already in publishing. Let me see if we can do a next release or a patch release shortly.

Craigacp commented 1 month ago

Ok, thanks for the update.