search

microsoft / onnxruntime-extensions

onnxruntime-extensions: A specialized pre- and post- processing library for ONNX Runtime
MIT License
340 stars 91 forks source link

"com.microsoft.onnxruntime_extensions" is not a valid bundle identifier #825

Open ronyfadel opened 1 month ago

ronyfadel commented 1 month ago

the exported framework has a bundle identifier of "com.microsoft.onnxruntimeextensions", which is invalid (because of the "") and Xcode is starting to reject it.

wenbingl commented 1 month ago

@edgchen1 , any suggestions?

edgchen1 commented 1 month ago

@edgchen1 , any suggestions?

maybe rename it to "com.microsoft.onnxruntime-extensions".

https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleidentifier?language=objc

ronyfadel commented 1 month ago

https://github.com/microsoft/onnxruntime-extensions/pull/829

ronyfadel commented 4 weeks ago

@edgchen1 @wenbingl can we create a new release please, both here and in https://github.com/microsoft/onnxruntime-swift-package-manager ?

The issues will start piling up soon as this breaks the package in Xcode 16.0

wenbingl commented 3 weeks ago

@apsonawane, can you cherry-pick PR https://github.com/microsoft/onnxruntime-extensions/pull/829 to the release branch, which is minor change but fixed a very important issue?

ronyfadel commented 3 weeks ago

Hey @apsonawane, @wenbingl , any updates to this?

The way I see it we'll need a new release in this project, and a new one at https://github.com/microsoft/onnxruntime-swift-package-manager that references it.

apsonawane commented 3 weeks ago

Hello @ronyfadel, we are planning on releasing this week will keep you updated.

Thank you!