search

microsoft / onnxruntime-swift-package-manager

A light-weight repository for providing Swift Package Manager support for ONNX Runtime.
MIT License
32 stars 16 forks source link

Swift Package cannot pass Archive Validation #23

Open djrluna opened 1 month ago

djrluna commented 1 month ago

Hello, I am using the onnx swift package in my iOS project, when attempting archive and upload a build to the TestFilght, it is failing validation with the following errors. It appears there are two errors, the statically linked framework needs to set MinimumOSVersion in its info .plist. Also the onnxruntime_extensions looks like it needs to renamed to not use underscores.

MinimumOSVersion. Apps that only support 64-bit devices must specify a deployment target of 8.0 or later. MinimumOSVersion in 'MyApp.app/Frameworks/onnxruntime.framework' is ''.

Asset validation failed
Invalid MinimumOSVersion. Apps that only support 64-bit devices must specify a deployment target of 8.0 or later. MinimumOSVersion in 'MyApp.app/Frameworks/onnxruntime_extensions.framework' is ''.

Asset validation failed
Missing Info.plist value. A value for the key 'MinimumOSVersion' in bundle MyApp.app/Frameworks/onnxruntime.framework is required. 

Asset validation failed
Missing Info.plist value. A value for the key 'MinimumOSVersion' in bundle MyApp.app/Frameworks/onnxruntime_extensions.framework is required. 

Asset validation failed
This bundle is invalid. The bundle at path Payload/Interview.app/Frameworks/onnxruntime_extensions.framework has an invalid CFBundleIdentifier 'com.microsoft.onnxruntime_extensions' There are invalid characters(characters that are not dots, hyphen and alphanumerics) that have been replaced with their code point 'com.microsoft.onnxruntime\u005fextensions' CFBundleIdentifier must be present, must contain only alphanumerics, dots, hyphens and must not end with a dot. [see the Core Foundation Keys at https://developer.apple.com/library/content/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/TP40009249-102070-TPXREF105] 

Asset validation failed
Invalid Bundle. The bundle MyApp.app/Frameworks/onnxruntime.framework does not support the minimum OS Version specified in the Info.plist. 

Asset validation failed
Invalid Bundle. The bundle MyApp.app/Frameworks/onnxruntime_extensions.framework does not support the minimum OS Version specified in the Info.plist.

I do not get the errors when archiving and uploading using cocoa pods. But would much rather be using Swift Packages as Onnx is the only pod being used in my project. Thank you!

ronyfadel commented 4 weeks ago

This bundle is invalid. The bundle at path Payload/Interview.app/Frameworks/onnxruntime_extensions.framework has an invalid CFBundleIdentifier 'com.microsoft.onnxruntime_extensions'

this one has been fixed in com.microsoft.onnxruntime_extensions

ronyfadel commented 4 weeks ago

This bundle is invalid. The bundle at path Payload/Interview.app/Frameworks/onnxruntime_extensions.framework has an invalid CFBundleIdentifier 'com.microsoft.onnxruntime_extensions'

this one has been fixed in com.microsoft.onnxruntime_extensions

cc @edgchen1

tqtifnypmb commented 3 weeks ago

This bundle is invalid. The bundle at path Payload/Interview.app/Frameworks/onnxruntime_extensions.framework has an invalid CFBundleIdentifier 'com.microsoft.onnxruntime_extensions'

this one has been fixed in com.microsoft.onnxruntime_extensions

cc @edgchen1

Should we wait for the next release, or should we just re-fetch the package?