No support for macOS in Package.swift

microsoft / onnxruntime-swift-package-manager

A light-weight repository for providing Swift Package Manager support for ONNX Runtime.

MIT License

30 stars 10 forks source link

No support for macOS in Package.swift #5

Closed fjtrujy closed 6 months ago

fjtrujy commented 1 year ago

Currently, the package just supports iOS platforms: [.iOS(.v11)],, what's blocking us for not allowing it for .macOS as well?

Cheers.

anthonydito commented 11 months ago

Agree! Would be great to have support for MacOS as well. Is this possible, or any guide for how to do this?

anthonydito commented 10 months ago

@YUNQIUGUO @edgchen1 - would you have any feedback about how to do this in a fork? Seems that some of the dependencies are iOS only

YUNQIUGUO commented 10 months ago

hi thanks for raising this issue.

Currently, we don't distribute pod binary targets for macOS yet. Adding macOS support is on ORT 1.17 task list.

After that, hopefully it will be easy to configure macOS platform apart from iOS here in Package.swift and pointing to the macOS pod binary target, etc.

YUNQIUGUO commented 6 months ago

Close this issue as now macOS is officially supported in Package.swift now.

Please reopen the issue if there's any questions.

fjtrujy commented 6 months ago

Hello @YUNQIUGUO , could you please make a new release then? currently, the only way is pointing to main/master which is not the best approach.

Cheers