microsoft / onnxruntime

ONNX Runtime: cross-platform, high performance ML inferencing and training accelerator
https://onnxruntime.ai
MIT License
14.1k stars 2.84k forks source link

Dll version of Microsoft.ML.OnnxRuntime.dll is 0.0.0.0 #21475

Open sportbilly21 opened 1 month ago

sportbilly21 commented 1 month ago

Describe the issue

System Information (please complete the following information):

OS & Version: either Windows 10 or 11 ML.NET Version: versions 1.7 and 3.0 Microsoft.ML.OnnxRuntime.Gpu version 1.15.1 and 1.18.1 .NET Version: .netframework 4.7 Describe the bug After building the solution the version of the Microsoft.ML.OnnxRuntime.dll is 0.0.0.0 This is not causing any issues if you are running the application through the Visual Studio. But we create an installer with Wix for installation in production PC When you install the software in Windows, the OS and wix due to the version of the dll being zero, they think the dll is corrupted and the installation cannot continue as the installer tries to recover the corrupted dll.

We have a work around by changing the version of the above dll but from my understanding dlls should not have 0 as a version

Screenshot 2024-04-19 084244

Urgency

No response

Target platform

Windows 10

Build script

The Dll version has an issue

Error / output

Screenshot 2024-04-19 084244

Visual Studio Version

2019 and 2022

GCC / Compiler Version

No response

skottmckay commented 1 month ago

There is a PackageVersion property that can be set but the packaging pipeline isn't passing through the ORT version currently. We'll look at updating it so that the version is set for official release builds.

sportbilly21 commented 1 month ago

Many thanks for your quick response. Please let us know when this is fixed so I can update also our solution

sportbilly21 commented 1 month ago

Hi many thanks for trying to resolve this so quickly, I have tried the lastest Nuget package 1.18.1 either the GPU, which I am using in the app, and the CPU one, but the version is still 0.0.0.0 image

Can you please let me know if this fix is incluced in the 1.18.1? Many thanks

skottmckay commented 1 month ago

Change will be in the 1.19 release

skottmckay commented 1 month ago

The nightly packages have the update if you want to verify: https://aiinfra.visualstudio.com/PublicPackages/_artifacts/feed/ORT-Nightly

sportbilly21 commented 1 month ago

Thank you very much for the update.