search

microsoft / onnxruntime

ONNX Runtime: cross-platform, high performance ML inferencing and training accelerator
https://onnxruntime.ai
MIT License
14.78k stars 2.94k forks source link

Fix build for linux python wheel #22801

Closed adrianlizarraga closed 1 week ago

adrianlizarraga commented 1 week ago

Description

Fixes command for building Linux python packages by preventing an empty -p command-line option from being passed to a subsequent build script: https://github.com/microsoft/onnxruntime/blob/1f3b675453e8412e5c084bfb95997967d0c2eec2/tools/ci_build/github/linux/run_python_dockerbuild.sh#L37

Motivation and Context

A recent PR introduced a new optional command-line option (-p) to pass custom python exe paths. We need to check if the option is empty before forwarding the option to a separate build script.

jchen351 commented 1 week ago

I have a separate PR to fix the same issue #22803, but I think we can merge both since both added an extra layer of protections.

adrianlizarraga commented 1 week ago

I have a separate PR to fix the same issue #22803, but I think we can merge both since both added an extra layer of protections.

@jchen351 Sounds good. Can you please take another pass at the PR? I addressed your comment.