microsoft / onnxscript

ONNX Script enables developers to naturally author ONNX functions and models using a subset of Python.
https://onnxscript.ai/
MIT License
271 stars 53 forks source link

Fix baddbmm and scalar_tensor #1837

Closed justinchuby closed 4 weeks ago

justinchuby commented 4 weeks ago
  1. Handle baddbmm when scalars are SymFloat
  2. Accept bool as scalar_tensor input

Fixes https://github.com/justinchuby/torch-onnx/issues/42

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.06%. Comparing base (22708e8) to head (cd2bcb8). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1837 +/- ## ======================================= Coverage 75.06% 75.06% ======================================= Files 249 249 Lines 27042 27044 +2 Branches 4939 4941 +2 ======================================= + Hits 20298 20300 +2 Misses 5799 5799 Partials 945 945 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 weeks ago

Test Results

     24 files  ±0      24 suites  ±0   2h 45m 9s :stopwatch: + 2m 58s  14 118 tests  - 1  11 743 :white_check_mark:  -  3    2 336 :zzz: + 1   32 :x: ±0   7 :fire: +1  354 873 runs   - 7  81 001 :white_check_mark:  - 25  273 617 :zzz: +17  212 :x: ±0  43 :fire: +1 

For more details on these failures and errors, see this check.

Results for commit 9f309e91. ± Comparison against base commit 22708e86.

This pull request removes 1 test. ``` onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function_aten_baddbmm ```
This pull request skips 1 test. ``` tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_040_aten_baddbmm ```

:recycle: This comment has been updated with latest results.