search

microsoft / opengcs

Moved to https://github.com/microsoft/hcsshim/tree/master/internal/guest. If you wish to open PRs/submit issues please do so against https://github.com/microsoft/hcsshim.
MIT License
83 stars 41 forks source link

Kernel patches need a Signed-off-by (DCO) line #28

Closed rn closed 7 years ago

rn commented 7 years ago

https://github.com/Microsoft/opengcs/blob/master/kernelconfig/4.11/patch_9pfs_vsock-transport.patch and https://github.com/Microsoft/opengcs/blob/master/kernelconfig/4.11/patch_lower-the-minimum-PMEM-size.patch as well as commits 29e6c6204845176c78c7840377a72389d188563c from https://github.com/dcui/linux.git do not have the the required Signed-off-by messages in the commit. Without we (Docker/LinuxKit) can't incorporate them into our kernel.

dcui commented 7 years ago

Please feel free to add "Signed-off-by: Dexuan Cui decui@microsoft.com" for any commit of mine (Dexuan Cui's) from my git repo https://github.com/dcui/linux.git. :-)

rn commented 7 years ago

@dcui the instruction are to cherry pick your commits from your tree so I think your commits should have your DCO. I also assume you'll try to upstream the branch so this has to be done anyway (along with detailed commit messages)

dcui commented 7 years ago

OK, I added my Signed-off-by and pushed it to a new branch just now: https://github.com/dcui/linux/commits/decui/hv_sock/v4.11/20170511-debug-0628-with-signed-off-by-of-dexuan-fixed

And soccerGB has helped to update the document accordingly: https://github.com/Microsoft/opengcs/pull/32#event-1159717050

soccerGB commented 7 years ago

Thanks for opening this tracking issue. It's all addressed.

rn commented 7 years ago

thanks for the quick turnaround