search

microsoft / opengcs

Moved to https://github.com/microsoft/hcsshim/tree/master/internal/guest. If you wish to open PRs/submit issues please do so against https://github.com/microsoft/hcsshim.
MIT License
83 stars 41 forks source link

Terminate all other container processes when the init exits #371

Closed kevpar closed 4 years ago

kevpar commented 4 years ago

Previously, if the container init spawned a child process which inherited its stdio, then exited, gcs would continue waiting until all child processes terminated. This only occurs when the container does not have its own pid namespace, as otherwise the kernel terminates all processes in the namespace automatically. To preserve this semantic even when the namespace is shared, we now explicitly kill all other container processes when its init exits.

Signed-off-by: Kevin Parsons kevpar@microsoft.com

katiewasnothere commented 4 years ago

@kevpar I don't think you pushed the most recent comment change

kevpar commented 4 years ago

Test for this: https://github.com/microsoft/hcsshim/pull/778