Remove dax mount option to avoid 5.4 kernel hard failure

microsoft / opengcs

Moved to https://github.com/microsoft/hcsshim/tree/master/internal/guest. If you wish to open PRs/submit issues please do so against https://github.com/microsoft/hcsshim.

MIT License

83 stars 41 forks source link

Remove dax mount option to avoid 5.4 kernel hard failure #375

Closed dcantah closed 4 years ago

dcantah commented 4 years ago

Removed dax mount option to circumvent the 5.4 kernel hard failure on unsupported dax devices. Previously if the block device wasn't supported the kernel would simply silently fail. This behavior was changed with this patch https://patchwork.kernel.org/patch/10631361/.

This change should be reverted whenever dax is properly supported for our pmem devices.

Signed-off-by: Daniel Canter dcanter@microsoft.com

kevpar commented 4 years ago

I know we don't run them automatically, but it would be good to update the test here as well: https://github.com/microsoft/opengcs/blob/master/internal/storage/pmem/pmem_test.go

dcantah commented 4 years ago

@kevpar true true. Fixing