microsoft / openjdk-docker

Repository of Container Images for the official MSFT Build of OpenJDK
https://mcr.microsoft.com/product/openjdk/jdk/about
MIT License
8 stars 18 forks source link

Sign docker images #90

Closed theodor-franke closed 3 months ago

theodor-franke commented 8 months ago

To enable a full chain of trust and verify the docker image it would be relay beneficial that you sign your images.
Google distroless images for example are signed using cosign. Link to google distroless verification instruction

karianna commented 8 months ago

@d3r3kk - What is the std practice for MSFT images here?

d3r3kk commented 8 months ago

This is indeed something that MSFT does internally, and we will adopt the practice over the coming month or so. @Luigi96 may be able to get to it with our team.

joe-braley commented 6 months ago

The current iteration of our images should be signed. Their signatures can be discovered using the following command: image image

If there is any issues observed, please let us know!

karianna commented 6 months ago

^^ @theodor-franke

janigabor commented 4 months ago

Indeed, the signature can be discovered with oras. Not sure however how to verify the signature? Notation seems not to be able to find the signatures.

image

karianna commented 4 months ago

@joe-braley Can you confirm the verification steps and whether we have that listed on our docs page (download area).

janigabor commented 4 months ago

Pulling the image with content trust turned on without any additional settings does not work either:

image

Any documentation regarding verifying the signatures would be greatly appreciated

joe-braley commented 4 months ago

Hey folks! I have reviewed our recommended process to verify the signatures. Please follow the steps below:

Verifying Microsoft's build of OpenJDK image signatures:

image

Please let us know if there are any issues with the content above!

karianna commented 4 months ago

Once verified, @brunoborges to determine if we add this to our official doc set.

janigabor commented 3 months ago

I was able to verify the images using the provided documentation, thank you.