microsoft / openssl

A cross-platform cryptographic library
133 stars 57 forks source link

Update to OpenSSL 1.0.2n and improve the entropyRT() implementation. #49

Closed MouriNaruto closed 6 years ago

MouriNaruto commented 6 years ago

Mouri

msftclas commented 6 years ago

CLA assistant check
All CLA requirements met.

noloader commented 6 years ago

Use IBufferByteAccess instead of Platform::Array to reduce overhead.

Windows really needs to provide a native method to get a seed on all platforms.

The Botan and Crypto++ library disable Random Number Generators because they are not managed libraries. They cannot use RNGCryptoServiceProvider, IBufferByteAccess, CryptographicBuffer.GenerateRandom, and friends.

MouriNaruto commented 6 years ago

Windows Runtime is native framework based on COM. So, you can use Windows Runtime interfaces on native libraries.

PS: OpenSSL is a native library. So you should trust my words.

@noloader

khouzam commented 6 years ago

Hi @MouriNaruto,

Thanks for the update, would you mind splitting this into 2 pull requests? One to update to 1.0.2.n and another one for the entropy? Or I can do the update to 1.0.2n and then you can make the PR to add the entropy improvements.

Thanks.

MouriNaruto commented 6 years ago

Thank you. I don't mind, I'll do it as soon as possible.

MouriNaruto commented 6 years ago

Hi, @khouzam

https://github.com/Microsoft/openssl/pull/51

It is the pull request that only update to OpenSSL 1.0.2n. I will create the second pull request as soon as possible after you merged that.

khouzam commented 6 years ago

Thank you for the code. I've merged it into the OpenSSL_1_0_2_WinRT-stable branch.

MouriNaruto commented 6 years ago

Thank you for your help. This is my first pull request in other people's repository.