search

microsoft / openvmm

Home of OpenVMM and OpenHCL.
http://openvmm.dev/
MIT License
1.36k stars 59 forks source link

openhcl_boot: fix lints #166

Closed romank-msft closed 1 day ago

romank-msft commented 1 day ago

slipped in with https://github.com/microsoft/openvmm/commit/6d5ad4612ef99dc80c8e64be2be40717a09e391e. The CI failed but the PR was merged anyways

daprilik commented 1 day ago

Thank you for the fixup PR Roman!

For posterity: Ben is taking point on investigating why the branch rules allowed the PR to merge without passing all clippy lints. Seems we might've tweaked a setting while firefighting CI issues last week.

benhillis commented 1 day ago

Thank you for the fixup PR Roman!

For posterity: Ben is taking point on investigating why the branch rules allowed the PR to merge without passing all clippy lints. Seems we might've tweaked a setting while firefighting CI issues last week.

I believe we had two branch protection rules that were conflicting, this should be resolved now.