search

microsoft / openvmm

Home of OpenVMM and OpenHCL.
http://openvmm.dev/
MIT License
1.36k stars 59 forks source link

flowey/gh: ensure the "all good" job does what its supposed to do #176

Closed daprilik closed 8 hours ago

daprilik commented 1 day ago

It seems that on github, this job never actually did what it was supposed to do, which was:

Instead, it seems that in the case of any previous job failing, GitHub Actions would simply skip executing the "all good" job entirely, and treat the skip as a "pass" of the (required) check. An interesting default indeed...

We never noticed this as we would previously run the PrivateVsoBuild job, which was a superset of all open-source checks, and would therefore fail if any open-source check failed, causing the PR to be blocked even through the "all good" check was ostensibly "passed".

This PR should fix things up such that our "all good" job does what its supposed to do, by relying on a workaround suggested in https://github.com/actions/runner/issues/2566 (albeit, a slightly tweaked variant of it).

I also switched the job to run on a Linux machine, which I believe is marginally faster to provision and execute on.

daprilik commented 1 day ago

Looking promising: seems my totally on purpose doc issues were correctly identified by the job, causing it to fail as expected.

image

benhillis commented 8 hours ago

After this is merged I will tweak the required status checks to only have the openvmm checkin gates job.