search

microsoft / openvmm

Home of OpenVMM and OpenHCL.
http://openvmm.dev/
MIT License
1.51k stars 72 forks source link

unsafe approvers does not work like ADO #31

Open chris-oo opened 2 months ago

chris-oo commented 2 months ago

Anyone in the hvlite team can signoff on any PR, because github does not have a stock way of enforcing every required reviewer signs off, only that a set number of reviewers sign off. See https://github.com/orgs/community/discussions/23765

One way of accomplishing this could be some more github actions that assign a unsafe-reviewers-required label, and unsafe-reviewers-approved labels that are driven by those teams.

chris-oo commented 2 months ago

Actually, the right thing to do is have the unsafe-reviewers.py script to validate that someone from the unsafe reviewers signed off, and mark red otherwise.