reverting the exit on fail option

kevsers commented 6 years ago

What does this PR do? Please provide some context

Reverts the exit on fail option from the create_superuser.sh. That is causing BVT/INT deployments where continuous deployment is enabled as the user already exists. The option was recently added. I have checked the previous successful logs of BVT, they all have failure logs in creating the oxamaster account (as it already exists, since BVT is not a brand new deployment) but continue to execute. The better solution would be to actually check if the account exist first, but for a quick fix I am just reverting the change.

Where should the reviewer start?

create_superuser.sh

How can this be manually tested? (brief repro steps and corpnet-URL with change)

What are the relevant TFS items? (list id numbers)

Definition of done:

[ ] Title of the pull request is clear and informative
[ ] Add pull request hyperlink to relevant TFS items
[ ] For large or complex change: schedule an in-person review session
[ ] This change has appropriate test coverage
[ ] Get at least two approvals

Reminders DURING merge

If you're merging from a short-term (feature) branch into a long-term branch (like dev, release, or master) then "Squash and merge" to keep our history clean.
If merging from two longterm branches (like cherry picks from upstream, dev to release, etc) then "Create merge commit" to preserve individual commits.

sdolenc commented 6 years ago

this is an okay temporary fix, but scripts invoked by ansible should a) be idempotent and b) report their failures. in other words, we should eventually investigate why this script can fail, fix that, and re-enable "dash e"

sdolenc commented 6 years ago

In any event: thanks for finding and fixing this! I made this change with the expectation that this script was reliable

microsoft / oxa-tools