microsoft / oxa-tools

Open edX on Azure Tools
MIT License
37 stars 99 forks source link

(WIP) separating shared configs (experiment to fix STAMP deploy) #289

Closed sdolenc closed 6 years ago

sdolenc commented 6 years ago

What does this PR do? Please provide some context

STAMP deployments to our BVT environment (using oxa/dev.fic) have been failing. This change attempts to repair this by undoing some of the cleanup from #284 . It puts mysql settings in their original place within the yml files in the config folder

Where should the reviewer start?

n/a. short review

How can this be manually tested? (brief repro steps and corpnet-URL with change)

deploy STAMP using odf_restoreYml (or oxa/dev.fic after merge)

What are the relevant TFS items? (list id numbers)

109562

Definition of done:

Reminders DURING merge

  1. If you're merging from a short-term (feature) branch into a long-term branch (like dev, release, or master) then "Squash and merge" to keep our history clean.
  2. If merging from two longterm branches (like cherry picks from upstream, dev to release, etc) then "Create merge commit" to preserve individual commits.