There are tests we run for every PR into our oxa/master.fic . One of these tests (deploying devstack using the latest upstream edx master) will fail due to breaking changes in openedx. The SKU is not essential so this change disables it with a comment explaining why. We'll also "fail fast" if the particular installation is attempted outside of automating testing.
How can this be manually tested? (brief repro steps and corpnet-URL with change)
Automating testing will continue succeeeding
What are the relevant TFS items? (list id numbers)
n/a. test fix required for future merges into oxa/master.fic
Definition of done:
[x] Title of the pull request is clear and informative
[ ] Add pull request hyperlink to relevant TFS items
[x] For large or complex change: schedule an in-person review session
[x] This change has appropriate test coverage
[ ] Get at least two approvals
Reminders DURING merge
If you're merging from a short-term (feature) branch into a long-term branch (like dev, release, or master) then "Squash and merge" to keep our history clean.
If merging from two longterm branches (like cherry picks from upstream, dev to release, etc) then "Create merge commit" to preserve individual commits.
What does this PR do? Please provide some context
There are tests we run for every PR into our oxa/master.fic . One of these tests (deploying devstack using the latest upstream edx master) will fail due to breaking changes in openedx. The SKU is not essential so this change disables it with a comment explaining why. We'll also "fail fast" if the particular installation is attempted outside of automating testing.
Note: The "breaking" change is https://github.com/edx/configuration/pull/4492/ . We should adopt the modern containerized devstack as part of our move to Hawthorne.
Where should the reviewer start?
n/a. simple review
How can this be manually tested? (brief repro steps and corpnet-URL with change)
Automating testing will continue succeeeding
What are the relevant TFS items? (list id numbers)
n/a. test fix required for future merges into oxa/master.fic
Definition of done:
Reminders DURING merge