search

microsoft / oxa-tools

Open edX on Azure Tools
MIT License
36 stars 103 forks source link

update utililies.sh to fix issue #355 #337

Closed kevmax1 closed 6 years ago

kevmax1 commented 6 years ago

I solve problem by adding new function in /oxa-tools/templates/stamp/utilities.sh

add-key-adv() { sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys EB3E94ADBE1229CF sudo apt-get update } and i call this function inside install-tools() function in the same file (utilities.sh)

msftclas commented 6 years ago

CLA assistant check
All CLA requirements met.

eltoncarr commented 6 years ago

Too many other changes are bundled in here for the intended fix. Please update your source to latest first and re-submit / update the PR. Given the severity of this issue, it would be great to provide this as quickly as possible for consideration since this is a fix we were working on already. It would be excellent to get a community contribution here but time is of the essence and we do appreciate your effort.

kevmax1 commented 6 years ago

I updated my sources and fix conflicts should I redo a pull request?

eltoncarr commented 6 years ago

Yes, update your source & target the appropriate branch for PR. My suggestion is, pull a fresh copy of oxa/dev.fic, apply your changes and send an new (or updated) PR for it. That should be cleaner...

Just to re-iterate the point, given the nature of the change and the need to get it updated asap, please provide an update at the earliest for consideration.

eltoncarr commented 6 years ago

Fix already in place. Closing...