microsoft / oxa-tools

Open edX on Azure Tools
MIT License
36 stars 103 forks source link

Merge d2r - Switch from Find-AzureRmResource to Get-AzureRmResource (#351) #352

Closed eltoncarr closed 6 years ago

eltoncarr commented 6 years ago

What does this PR do? Please provide some context

Switch from using Find-AzureRmResource cmdlet to Get-AzureRmResource cmdlet. Find-AzureRmResource was merged with Get-AzureRmResource in the v6.0.0 of the Azure Powershell Cmdlets (May 2018).

Where should the reviewer start?

The changes

How can this be manually tested? (brief repro steps and corpnet-URL with change)

On a clean deployment instance with the latest AzureRM module installed, you will encounter an error about "Find-AzureRmResource" not found. With this change, that error goes away.

What are the relevant TFS items? (list id numbers)

N/A

Definition of done:

Reminders DURING merge

  1. If you're merging from a short-term (feature) branch into a long-term branch (like dev, release, or master) then "Squash and merge" to keep our history clean.
  2. If merging from two longterm branches (like cherry picks from upstream, dev to release, etc) then "Create merge commit" to preserve individual commits.
eltoncarr commented 6 years ago

Thanks