microsoft / oxa-tools

Open edX on Azure Tools
MIT License
36 stars 103 forks source link

Merge ms2m - Fix: Apply Cli version configuration override (#358) #361

Closed eltoncarr closed 6 years ago

eltoncarr commented 6 years ago

What does this PR do? Please provide some context

Apply configuration override for Azure Cli version for storage account creation

Where should the reviewer start?

The changes.

How can this be manually tested? (brief repro steps and corpnet-URL with change)

Run powershell -f Create-StorageContainer.ps1 (with the appropriate parameters)

Without the changes, the setup fails with Login Failed | const { required, nullable } = mapper; With the changes, the error goes away.

What are the relevant TFS items? (list id numbers)

N/A

Definition of done:

Reminders DURING merge

  1. If you're merging from a short-term (feature) branch into a long-term branch (like dev, release, or master) then "Squash and merge" to keep our history clean.
  2. If merging from two longterm branches (like cherry picks from upstream, dev to release, etc) then "Create merge commit" to preserve individual commits.