Oxa/oxa tools - Githubissues

RepoCloudSwyft commented 5 years ago

What does this PR do? Please provide some context

Where should the reviewer start?

How can this be manually tested? (brief repro steps and corpnet-URL with change)

What are the relevant TFS items? (list id numbers)

Definition of done:

[ ] Title of the pull request is clear and informative
[ ] Add pull request hyperlink to relevant TFS items
[ ] For large or complex change: schedule an in-person review session
[ ] This change has appropriate test coverage
[ ] Get at least two approvals

Reminders DURING merge

If you're merging from a short-term (feature) branch into a long-term branch (like dev, release, or master) then "Squash and merge" to keep our history clean.
If merging from two longterm branches (like cherry picks from upstream, dev to release, etc) then "Create merge commit" to preserve individual commits.

msftclas commented 5 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: RepoCloudSwyft sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

eltoncarr commented 5 years ago

Are these changes still viable, @prabhanshu ?

prabhanshu commented 5 years ago

@eltoncarr No, these changes are specific to their configuration.

For e.g: LMS_URL=mytest_lms.$BASE_URL CMS_URL=mytest_cms.$BASE_URL PREVIEW_URL=mytest_preview.$BASE_URL

microsoft / oxa-tools

Oxa/oxa tools #462