Closed belkiss closed 1 year ago
@microsoft-github-policy-service agree
Hi belkiss, this is a great addition! Caching the OpenSSL build should really speed up the iteration. Since the GitHub hosted runners only support VS 2022 and latest WDK, I had another branch with full VS 2022 migration, which has now been pushed to main. The verify.yml similar to yours, but not as good. Would you mind merging your msbuild.yml changes to main and send another PR? Thanks!
Hello! Will do! Note that vs2019 is supported in the windows-2019
images, but vs2022 update is even better :)
Should be done :)
Here are the changes compared to vanilla:
Looks good @belkiss, thanks.
Np! Thank you!
Heya!
This PR adds basic CI using GitHub Actions using the vs2019 image. Had to tweak the P4VFS.Driver vcxproj file to make it use the latest SDK in the environment instead of being hardcoded.
The workflow file builds Debug and Release, and also caches the OpenSSL artifacts using the environment version + the hash of the OpenSSL.Module.cs file to ensure it is rebuilt when needed.
And thanks for releasing this! (expect a few other PR, you can have a look at the dev branch in my fork for a sneak peek ;)).
Cheers!