search

microsoft / parallel-prettier

Concurrent prettier runner
MIT License
197 stars 18 forks source link

Inherit .gitignore #9

Open lukeapage opened 3 years ago

lukeapage commented 3 years ago

Prettier inherits .gitignore where as parrallel-prettier doesn't

I'm happy to make a PR but how do you want to achieve it? allow multiple ignore paths? include it if it exists?

thernstig commented 8 months ago

@lukeapage Prettier does not inherit .gitignore, see https://prettier.io/docs/en/ignore.html

Is this the cause for your issues: https://github.com/microsoft/parallel-prettier/issues/25?

lukeapage commented 8 months ago

The docs you pointed at say this:

Prettier will also follow rules specified in the ".gitignore" file if it exists in the same directory from which it is run.

thernstig commented 8 months ago

@lukeapage to be fair, that page was updated one month ago: https://github.com/prettier/prettier/commit/9ebcf9b0ffdf568d884f748510fd6b730dd28010

When this issue was written Prettier did not follow .gitignore.

I think https://github.com/microsoft/parallel-prettier/issues/23 is needed first then, and maybe it will/would be done as part of this, but I also believe it is good to keep this issue open then.