search

microsoft / perfview

PerfView is a CPU and memory performance-analysis tool
http://channel9.msdn.com/Series/PerfView-Tutorial
MIT License
4.05k stars 695 forks source link

Sid data type support discussion #128

Open MatthewMWR opened 7 years ago

MatthewMWR commented 7 years ago

I have created a fork+branch with incomplete Sid data type support at https://github.com/MatthewMWR/perfview/tree/SidTypeSupport_2016-10 with extraction methods, test data covering multiple data layout scenarios, and a unit test.

If it will work for you, the compare URL is https://github.com/Microsoft/perfview/compare/master...MatthewMWR:SidTypeSupport_2016-10?expand=1

Currently this is missing a key element (why I haven't done a PR yet): In Registered/Dynamic parsing context we need to fix up the field lengths for Sid and following fields per-event (like with strings). I have the method to determine the length of the data, but I don't know where to implement the run time offset fixups.

vancem commented 7 years ago

Assigning to me to look at the PR that Matt has created above.

brianrob commented 4 years ago

@MatthewMWR is this something that you're still interested in pursuing? Can you also share if there was anymore progress on this that isn't documented here? Thanks.

MatthewMWR commented 4 years ago

Hi Brian. I haven't thought about this in ages, but I would like to see it through to completion. My memory is that the scenario seemed 95% solved. In trying to think of a next step, maybe I could break this into multiple smaller changes. For example the kernel case is done (IIRC), so we could get that out of the way before addressing the Dynamic case.