search

microsoft / perfview

PerfView is a CPU and memory performance-analysis tool
http://channel9.msdn.com/Series/PerfView-Tutorial
MIT License
4.09k stars 695 forks source link

TraceParserGen: xxxTaskGuid not defined #1351

Open dorian-apanel-intel opened 3 years ago

dorian-apanel-intel commented 3 years ago

I'm trying to compile cs code generated by TraceParserGen with custom manifest.

First problem I see is that guids passed to RegisterTemplate() are not defied. Then I found this comment in code

// as of today, the generated code won't compile because the task GUID is not defined
// TODO: define the xxxTaskGuid based on eventGUID attribute of <task> elements of the .man file

Is it going to be fixed? It happens both if I define eventGUID attribute or not.

brianrob commented 3 years ago

@dorian-apanel-intel, this can be fixed, but wasn't an issue that I was aware of. Would you be up for submitting a PR for this?

dorian-apanel-intel commented 3 years ago

Hi, I fixed it for myself. I'm going to propose a PR soon.

limulidae commented 10 months ago

Is this fixed?

brianrob commented 10 months ago

I don't believe that this has been fixed. Fixes to TraceParserGen have been held up behind a goal to create a test-bed for the tool first, as each time we take a change, we tend to break something.