search

microsoft / perfview

PerfView is a CPU and memory performance-analysis tool
http://channel9.msdn.com/Series/PerfView-Tutorial
MIT License
4.05k stars 695 forks source link

Clicking links in help to msdn.microsoft.com deadlocks PerfView #2045

Closed zivkan closed 3 weeks ago

zivkan commented 4 weeks ago

I was viewing ETL events, and clicked the help button for text filter. The help page has a link to .NET Regular Expressions. I clicked the link, got two error messages about javascript not working, and then PerfView stopped responding, and Windows had to kill the process.

Sorry I didn't make any effort to investigate this myself, but I thought I'd report it, rather than risk forgetting.

cincuranet commented 3 weeks ago

@brianrob I can replicate that. I think we should not try to load external content into our old web view and rather open default browser. Alternatively we can update to WebView2, but maybe that's overkill.

brianrob commented 3 weeks ago

@zivkan, thanks for reporting.

@cincuranet I think it's reasonable to launch a new browser if that's easy. In fact, we can likely just launch help in the browser directly. What do you think?

cincuranet commented 3 weeks ago

@brianrob I feel like showing help "inside" is valuable, mostly because it is nicely integrated.

I'll create PR for launching external content in browser.

brianrob commented 3 weeks ago

Sounds good. Thanks @cincuranet!