fix: arm64/kerneltracecontrol.dll file name

microsoft / perfview

PerfView is a CPU and memory performance-analysis tool

http://channel9.msdn.com/Series/PerfView-Tutorial

MIT License

4.1k stars 698 forks source link

fix: arm64/kerneltracecontrol.dll file name #2068

Open vaind opened 1 month ago

vaind commented 1 month ago

Fixes builds on case-sensitive systems. The actual DLL in the package is lowercase.

/usr/share/dotnet/sdk/8.0.303/Microsoft.Common.CurrentVersion.targets(5270,5): error MSB3030: Could not copy the file "/home/runner/.nuget/packages/microsoft.diagnostics.tracing.traceevent.supportfiles/1.0.28/lib/native/arm64/KernelTraceControl.dll" because it was not found. [/home/runner/work/sentry-dotnet/sentry-dotnet/modules/perfview/src/TraceEvent/TraceEvent.csproj::TargetFramework=netstandard2.0]

cincuranet commented 1 month ago

@brianrob Do we maybe want to rename the file in the package to have proper casing? Do you see any risk in doing that?

brianrob commented 1 month ago

@brianrob Do we maybe want to rename the file in the package to have proper casing? Do you see any risk in doing that?

I think this would be fine.