search

microsoft / perfview

PerfView is a CPU and memory performance-analysis tool
http://channel9.msdn.com/Series/PerfView-Tutorial
MIT License
4.1k stars 698 forks source link

Nuget package 3.1.13 fails to declare dependency #2070

Closed cg110 closed 1 month ago

cg110 commented 1 month ago

The 3.1.13 nuget package for Microsoft.Diagnostics.Tracing.TraceEvent fails to declare it has a dependency on Microsoft.Diagnostics.NETCore.Client

The dependency was added in: https://github.com/microsoft/perfview/commit/c847ec9392312c6159434cd87312040170303a35 and shows up as a dependent dll when examining referenced dlls in nuget package explorer (along with any other tooling that walks referenced dlls to confirm all needed dlls are present): image

I'm not sure it's needed at runtime, but the reference is there, suggesting it is needed.

brianrob commented 1 month ago

Thanks for reporting this @cg110. I had noticed this during code review, but only got part of the fix in. I've posted #2071 to finish it up. Unless you're using EventPipe streaming support, you should be fine, and won't see the new DLL get loaded.

cg110 commented 1 month ago

Great thank you.