search

microsoft / php-sdk-binary-tools

Tool kit for building PHP under Windows
BSD 2-Clause "Simplified" License
270 stars 79 forks source link

PHP 7.4 build failure with default dependencies #52

Closed cmb69 closed 5 years ago

cmb69 commented 5 years ago

PHP 7.4 unbundles liboniguruma, which currently is only available with the staging dependencies, but by default the stable dependencies are used. Therefore, builds which try to enable mbregex will fail. This is no problem with the rmtools, since these always use staging dependencies, but users who are doing their own builds with the plain SDK are likely to stumble over this.

I suggest to either use staging dependencies for PHP 7.4 temporarily (until first beta), or to push libonig to stable soon.

cmb69 commented 5 years ago

Well, we also should do something regarding the code duplication; as it is now, the code in phpsdk_deps.php is unused since Config::getCurrentStabilityName() never returns null .

weltling commented 5 years ago

It's probably fine adding that to stable, it's been a while libonig was used for the builds and it seems ok. There was something else unbundled, libsqlite? I just lost the outline of that change :) Need to check that and sync to stable as well.

Thanks.

cmb69 commented 5 years ago

libsqlite3 is unbundled as of PHP 7.4.0 as well, but the dependency is already in stable.

weltling commented 5 years ago

All the deps are synchronized now. Please handle the code dup in a separate issue.

Thanks.

cmb69 commented 5 years ago

Please handle the code dup in a separate issue.

See PR #54.