search

microsoft / php-sdk-binary-tools

Tool kit for building PHP under Windows
BSD 2-Clause "Simplified" License
270 stars 79 forks source link

Work around old-style constructors in PGO training case #53

Closed cmb69 closed 5 years ago

cmb69 commented 5 years ago

class.php of the pgo01org training case still uses PHP 4 style constructors, which trigger deprecation notices and as such may negatively affect the optimization. Until this will be fixed upstream, we're employing the workaround to modify the file during the PGO initialization step.

weltling commented 5 years ago

Merged, thanks! Btw. no need to mention pr in the code, instead you could put closes #53 into the commit msg (see github docs).

Thanks.

weltling commented 5 years ago

Ups, closes #51 i mean, the issue ticket.

Thanks.