search

microsoft / php-sdk-binary-tools

Tool kit for building PHP under Windows
BSD 2-Clause "Simplified" License
270 stars 79 forks source link

Bundle PHP 7.4 #67

Closed mvorisek closed 4 years ago

mvorisek commented 4 years ago

PHP 7.4 is out and it is the latest stable, so this version should be also bundled.

cmb69 commented 4 years ago

What do you mean by "be bundled"?

cmb69 commented 4 years ago

Ah, you're referring to https://github.com/microsoft/php-sdk-binary-tools/tree/master/bin/php. I don't see any need to bundle PHP 7.4 in addition. We may want to upgrade some time in the not too distant future, though.

mvorisek commented 4 years ago

@cmb69 Yes, the PHP in the bin/ dir. For example, we build some Windows extensions using this repo and then do quick testing using the bundled PHP. And currently it fails, as the PHP ext. API versions differ (we build with the latest/7.4 PHP version).

mvorisek commented 4 years ago

@weltling can you please upgrade the bundled PHP as in the past? - https://github.com/microsoft/php-sdk-binary-tools/commits/master/bin/php Thanks.

cmb69 commented 4 years ago

I have upgraded to PHP 7.3.13 now. To clarify: the SDK bundles a rather minimal PHP versions so that contained scripts written in PHP can be run. This bundled PHP should never be used to run on a public Webserver, and even for actual development purposes I strongly recommend to either use a self built PHP or to use a full release version.