search

microsoft / playwright-dotnet

.NET version of the Playwright testing and automation library.
https://playwright.dev/dotnet/
MIT License
2.47k stars 235 forks source link

[Bug]: Add deprecation notice to playwright-sharp-tool #1829

Closed TanayParikh closed 2 years ago

TanayParikh commented 2 years ago

Your question

Hello, I see the nuget package is still v0.192.0, while the latest release in the repo is v1.16.1. Will this be updated, or is there a new package source we should be utilizing?

mxschmitt commented 2 years ago

The new package is Microsoft.Playwright. The old one is considered deprecated and does not get updated anymore.

See here: https://www.nuget.org/packages/Microsoft.Playwright

And the banner here: https://www.nuget.org/packages/PlaywrightSharp/

Let us know if the old one is referenced somewhere incorrectly!

TanayParikh commented 2 years ago

Ah okay thanks for the clarification. I was just upgrading the package used in dotnet/aspnetcore, and was looking for the old package.

https://github.com/dotnet/aspnetcore/blob/c0778f05020f8d99481e479553dc024298c108dd/.config/dotnet-tools.json#L11-L16

Let us know if the old one is referenced somewhere incorrectly!

Would it be possible to update the playwright-sharp-tool nuget package to indicate deprecation like what you have with https://www.nuget.org/packages/PlaywrightSharp/

mxschmitt commented 2 years ago

Would it be possible to update the playwright-sharp-tool nuget package to indicate deprecation like what you have with https://www.nuget.org/packages/PlaywrightSharp/

this sounds reasonable to me! lets have this as an action item for this issue.

Thanks!

304NotModified commented 2 years ago

I see the deprecation warning on nuget.org, so this could be closed :)