search

microsoft / playwright-dotnet

.NET version of the Playwright testing and automation library.
https://playwright.dev/dotnet/
MIT License
2.47k stars 235 forks source link

[BUG] v1.19.0 is adding 50+ MB to my NuGet packages. #2022

Closed Xen0byte closed 2 years ago

Xen0byte commented 2 years ago

Context:

Describe the bug

Building a NuGet package for my project with a reference to v1.18.1 creates a 68kb NUPKG, however building the exact same solution but with a reference to v1.19.0 creates a 51,840kb NUPKG.

campersau commented 2 years ago

I guess it is because of https://github.com/microsoft/playwright-dotnet/pull/1955 which now includes the node / package when doing a dotnet pack. You can set PlaywrightPlatform=none either in the .csproj like

<PropertyGroup>
    <PlaywrightPlatform>none</PlaywrightPlatform>
</PropertyGroup>

or when running dotnet pack /p:PlaywrightPlatform=none.

https://playwright.dev/dotnet/docs/intro#bundle-drivers-for-different-platforms

Xen0byte commented 2 years ago

Aha, thanks @campersau, I must have missed this change in the recent changelogs. Please feel free to close this issue, if that is the intended behavior. 😊