Ship with embedded symbols so we get line numbers

microsoft / playwright-dotnet

.NET version of the Playwright testing and automation library.

https://playwright.dev/dotnet/

MIT License

2.47k stars 235 forks source link

Ship with embedded symbols so we get line numbers #2050

Closed SimonCropp closed 2 years ago

SimonCropp commented 2 years ago

so stuff like this is easier to debug

System.NullReferenceException: Object reference not set to an instance of an object.

System.NullReferenceException
Object reference not set to an instance of an object.
   at Microsoft.Playwright.Core.Browser.NewContextAsync(BrowserNewContextOptions options)
   at Microsoft.Playwright.Core.Browser.NewPageAsync(BrowserNewPageOptions options)

mxschmitt commented 2 years ago

Are you interested in contributing this to the project?

SimonCropp commented 2 years ago

absolutely. want a PR for this?

SimonCropp commented 2 years ago

side note. what branch should PRs target. main seems to target only netstandard https://github.com/microsoft/playwright-dotnet/blob/main/src/Playwright/Playwright.csproj#L10 but the current release also targets net5 https://github.com/microsoft/playwright-dotnet/blob/release-1.19/src/Playwright/Playwright.csproj#L10

mxschmitt commented 2 years ago

main is up2date, we recently changed the TFM to netstandard. It gets released released as stable in a few days.