microsoft / playwright-dotnet

.NET version of the Playwright testing and automation library.
https://playwright.dev/dotnet/
MIT License
2.47k stars 235 forks source link

[Regression]: PauseAsync/CodeGen no longer highlighting the exact location of locators on screen #2933

Closed Shehreem-Solirius closed 5 months ago

Shehreem-Solirius commented 5 months ago

Last Good Version

1.39

First Bad Version

1.40

Steps to reproduce

Note: I have not created a repo as it's not needed for this issue, please see steps below

  1. Run the following command in the terminal - npx playwright codegen https://guidance.submit-learner-data.service.gov.uk/
  2. Click any locator on screen
  3. Notice, the top left corner is highlighted rather than the exact location of the locator image

Expected behavior

I expect the exact location of the locator to be highlighted, e.g. in the image above, the search bar

Actual behavior

The top left corner of the screen is highlighed

Additional context

This is annoying when trying to create custom locators It also happens when running PauseAsync This used to work before we updated playwright due to older versions not supporting dotnet8, so we cannot downgrade to get the functionality This seems to only happen on our sites, Google for example, works fine

Environment

- Operating System: Windows
- Browser: Chromium
- .NET Version (TFM): net8.0
mxschmitt commented 5 months ago

I was able to reproduce it, looks like its fixed in 1.44 which we'll release in a couple of days.

Shehreem-Solirius commented 5 months ago

Amazing, thanks, looking forward to the update 😄

mxschmitt commented 5 months ago

I'll close it, since this gets fixed in 1.44.0 which we'll release shortly.